-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.5.0 Release #1516
Merged
Merged
v6.5.0 Release #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly update the secondary protocol to use that security manager
* It will be implicitly removed when the stream is closed
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
… made sure to add check in the iAP caee as well. Updated unit tests
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…ttps://github.com/smartdevicelink/sdl_ios into bugfix/issues_1480_1492_1496_1501_lockscreen_fixes
…round-crashes Only try to remove from run loop when we aren't closing
…templateConfiguration_param_not_set Fixed the Show RPC's templateConfiguration parameter not getting set
…emplate-configuration Add APIs to SDLTemplateConfiguration for Objective-C++ compatibility
…buttons_switching_templates_bug Fixed soft button operation never finishing if template does not support soft buttons
…ribe-returns-wrong-type Fix SystemCapabilityManager subscribe not returning the correct type
…_1496_1501_lockscreen_fixes Lockscreen bug fixes
…ityManager-Set-For-SecondaryProtocol Security manager set for secondary protocol
…k-test-failures Fix issues shown by OCMock 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit tests have been added to the individual bugs and features in this PR.
Core Tests
TBD
Core version / branch / commit hash / module tested against: [INSERT]
HMI name / version / branch / commit hash / module tested against: [INSERT]
Summary
This minor version release of the SDL iOS library fixes bugs identified with the SDL v6.4.1 release. It is a minor version release due to a bug fix that adds APIs for Objective-C++ projects only in order to work around a compatibility issue.
Changelog
Breaking Changes
Bug Fixes
SDLSystemCapabilityManager subscribeToCapabilityType:withObserver:selector:
not returning a BOOL as was declared (SystemCapabilityManager subscribeToCapabilityType:withObserver: returns an object instead of BOOL #1465).Show.templateConfiguration
RPC parameter not getting set properly (The Show RPC's templateConfiguration parameter is not set #1486).Tasks Remaining:
CLA